Review Request: Plasma doesn't follow Kiosk restrictions
Marco Martin
notmart at gmail.com
Wed Nov 10 17:49:42 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5823/#review8622
-----------------------------------------------------------
Ship it!
looks fine
trunk/KDE/kdelibs/plasma/applet.cpp
<http://svn.reviewboard.kde.org/r/5823/#comment9067>
i don't think repeating the check is really necessary but yeah, setting own immutability from globalconfig sounds right
- Marco
On 2010-11-10 16:39:31, Lubos Lunak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5823/
> -----------------------------------------------------------
>
> (Updated 2010-11-10 16:39:31)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Summary
> -------
>
> Probably as a result of r800724, Plasma doesn't seem to follow Kiosk restrictions at all (just grep the sources for where SystemImmutable is assigned to something - it isn't). This patch may possibly be a suitable fix.
>
>
> Diffs
> -----
>
> trunk/KDE/kdelibs/plasma/applet.cpp 1182745
>
> Diff: http://svn.reviewboard.kde.org/r/5823/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lubos
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101110/2196a9ab/attachment-0001.htm
More information about the Plasma-devel
mailing list