Review Request: Launchersupport in the Tasks-applet

[Anton Kreuzkamp]

> On 2010-11-07 17:46:39, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp, lines 224-229
> > <http://svn.reviewboard.kde.org/r/5786/diff/1/?file=40735#file40735line224>
> >
> >     instead of a stringlist, would it make more sense to have a config group for each launcher? e.g. something like:
> >     
> >     KConfigGroup launcherCg(&cg, "Launchers");
> >     launcherCg = KConfigGroup(&launcherCg, launcher->name());
> >     
> >     launcherCg.writeEntry("Url", launcher->url());
> >     lunchgerCg.writeEntry("Icon", ....

The config-file looks cleaner like with the stringlist, and as I don't see any disadvantages in this method I think it's the better one.


- Anton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5786/#review8540
-----------------------------------------------------------


On 2010-11-07 14:08:45, Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5786/
> -----------------------------------------------------------
> 
> (Updated 2010-11-07 14:08:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Implementation of the launchersupport in plasma's "Tasks"-applet. It depends on http://svn.reviewboard.kde.org/r/5785/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/CMakeLists.txt 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1187984 
> 
> Diff: http://svn.reviewboard.kde.org/r/5786/diff
> 
> 
> Testing
> -------
> 
> tested, everything worked well so far.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101109/0dec6788/attachment.htm