Review Request: Launchersupport in the Tasks-applet

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5786/#review8540
-----------------------------------------------------------


a great start; some rough edges to "sand off". since this affects UI, could you provide some screenshots (a screencast would be terrific, but that might be a lot of work if you don't already have a screencast setup on yoru system)


/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h
<http://svn.reviewboard.kde.org/r/5786/#comment8901>

    this method is already virtual in QGraphicsItem, no need to mar it as such here.



/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp
<http://svn.reviewboard.kde.org/r/5786/#comment8900>

    please don't remove this block, since it provides some in-code documentation as to something that is not being handled in the code.
    
    if anything, this should be turned into a switch statement.



/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp
<http://svn.reviewboard.kde.org/r/5786/#comment8902>

    honestly, i'd rather have this merged into AbstractTaskItem::paint.
    
    if it is a launcher, the drawBackground call wouldn't need to be made, and drawTask would need few modifications. this would also preserve features like painting of the busy status "for free".



/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp
<http://svn.reviewboard.kde.org/r/5786/#comment8903>

    whitspace around braces is incorrect here.



/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp
<http://svn.reviewboard.kde.org/r/5786/#comment8904>

    whitespace; should be if (item.length() == 4) {



/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp
<http://svn.reviewboard.kde.org/r/5786/#comment8905>

    instead of a stringlist, would it make more sense to have a config group for each launcher? e.g. something like:
    
    KConfigGroup launcherCg(&cg, "Launchers");
    launcherCg = KConfigGroup(&launcherCg, launcher->name());
    
    launcherCg.writeEntry("Url", launcher->url());
    lunchgerCg.writeEntry("Icon", ....


- Aaron


On 2010-11-07 14:08:45, Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5786/
> -----------------------------------------------------------
> 
> (Updated 2010-11-07 14:08:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Implementation of the launchersupport in plasma's "Tasks"-applet. It depends on http://svn.reviewboard.kde.org/r/5785/
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/CMakeLists.txt 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.h 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/applauncheritem.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskgroupitem.cpp 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/taskitemlayout.cpp 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.h 1187984 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/tasks.cpp 1187984 
> 
> Diff: http://svn.reviewboard.kde.org/r/5786/diff
> 
> 
> Testing
> -------
> 
> tested, everything worked well so far.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101107/d0d04e5b/attachment-0001.htm