Review Request: Launchersupport in libtaskmanager - final implementation
Anton Kreuzkamp
akreuzkamp at web.de
Tue Nov 9 15:08:06 CET 2010
> On 2010-11-07 18:07:13, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp, line 607
> > <http://svn.reviewboard.kde.org/r/5785/diff/1/?file=40715#file40715line607>
> >
> > as this is only used from the context menu action, this should be moved there. the actions are not public API while this is.
>
> Anton Kreuzkamp wrote:
> together with findLauncher() this is possible now, I'll change it.
toggleLauncherSettingforItem() emits the signals launcherAdded() and launcherRemoved() and as the Applet doesn't have an object of ToggleLauncherActionImpl, I can't simply move the signals there, so I see no possibility to move the method there.
- Anton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5785/#review8541
-----------------------------------------------------------
On 2010-11-07 13:19:14, Anton Kreuzkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5785/
> -----------------------------------------------------------
>
> (Updated 2010-11-07 13:19:14)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This is the final implementation of the launchersupport for libtaskmanager. Many parts of the initial implementation has been changed but now everything works as it should.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1193833
> trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1193833
>
> Diff: http://svn.reviewboard.kde.org/r/5785/diff
>
>
> Testing
> -------
>
> Tested and everything worked fine.
>
>
> Thanks,
>
> Anton
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101109/8344d5dc/attachment.htm
More information about the Plasma-devel
mailing list