Review Request: Launchersupport in libtaskmanager - final implementation

[Aaron Seigo]

> On 2010-11-07 18:07:13, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h, lines 129-147
> > <http://svn.reviewboard.kde.org/r/5785/diff/1/?file=40714#file40714line129>
> >
> >     with these changes, GroupManager gets a lot of API for launchers. similar API does not exist for windows, startups or groups, though. this seems like the "wrong" place for such API. why is it added here?
> >     
> >     if anything, it may make more sense to move addLauncher from GroupManager to TaskGroup. this will allow GroupManager to remain a manager of groups and TaskGroup can continue to manage collections of items.
> 
> Anton Kreuzkamp wrote:
>     It is possible that you have more than one root group (for every desktop there is one root group), but launchers need to be global, so you can't put in in TaskGroup. (I just see that the launcher gets added to just one rootgroup although, I'll change that)

"It is possible that you have more than one root group"

ah, right, due to the show-only-this-desktop thing. *sigh* ok, makes sense.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5785/#review8541
-----------------------------------------------------------


On 2010-11-07 13:19:14, Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5785/
> -----------------------------------------------------------
> 
> (Updated 2010-11-07 13:19:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is the final implementation of the launchersupport for libtaskmanager. Many parts of the initial implementation has been changed but now everything works as it should.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1193833 
> 
> Diff: http://svn.reviewboard.kde.org/r/5785/diff
> 
> 
> Testing
> -------
> 
> Tested and everything worked fine.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101108/1d8b0d6e/attachment-0001.htm