Review Request: Make custom colours work on the digital clock again

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5747/#review8508
-----------------------------------------------------------

Ship it!


one small change up, and then i guess it's good to go.


Screenshot: Updated
<http://svn.reviewboard.kde.org//r/5747/#scomment43>
    should also be disabled when the widgets are

- Aaron


On 2010-11-04 17:57:08, Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5747/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 17:57:08)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored.  This re-enables it, and also allows the user to choose a shadow colour.
> 
> This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1192604 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1192604 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1192604 
> 
> Diff: http://svn.reviewboard.kde.org/r/5747/diff
> 
> 
> Testing
> -------
> 
> Changing, saving and loading the settings worked in plasmoid-viewer.
> 
> 
> Screenshots
> -----------
> 
> The changed configuration
>   http://svn.reviewboard.kde.org/r/5747/s/546/
> Updated
>   http://svn.reviewboard.kde.org/r/5747/s/549/
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101104/eb7e0a4d/attachment.htm