Review Request: Make custom colours work on the digital clock again

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5747/
-----------------------------------------------------------

(Updated 2010-11-04 17:57:08.651004)


Review request for Plasma.


Changes
-------

Configuration dialog updated as per Aaron's suggestions.  No changes to rendering code.

I'm also not happy with option proliferation, but this at least is in line with the other font/styling options that are already in the dialog.


Summary
-------

Since the shadow was introduced for the digital clock a few weeks ago, the custom colour setting has been ignored.  This re-enables it, and also allows the user to choose a shadow colour.

This changes the configuration dialog and introduces a new option, which is why I'm submitting it for review before committing.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1192604 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1192604 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1192604 

Diff: http://svn.reviewboard.kde.org/r/5747/diff


Testing
-------

Changing, saving and loading the settings worked in plasmoid-viewer.


Screenshots
-----------

The changed configuration
  http://svn.reviewboard.kde.org/r/5747/s/546/
Updated
  http://svn.reviewboard.kde.org/r/5747/s/549/


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101104/449f5c55/attachment.htm