Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

[Ignat Semenov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4119/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This is the final version of the Pager configuration Dialog patch. Changes:

- Brought back radiobuttons
- Changed the "Display icons" checkbox to respect KDE style
- Introduced a ton of layouts and set a top-level layout so that the dialog scales properly now
- Centered the "Configure Desktops" button and made it huge

I plan to fix the layout issues for all plasmoid configuration dialogs, as time allows.
Now I'd like to know what's the rationale behind headers in configuration dialogs. They're redundant from my point of view as they duplicate the information which is on the left in the list of configuration pages. Maybe they can be removed? Not it Plasma, of course, but in KConfigurationDialog source.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pager.cpp 1129710 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/pager/pagerConfig.ui 1129710 

Diff: http://reviewboard.kde.org/r/4119/diff


Testing
-------

Built it and it really scales properly now. There is only a minor problem with Oxygen style and I've already filed a bug against Oxygen.


Thanks,

Ignat