[PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

[Alessandro Diaferia]

2010/5/23 Asraniel <asraniel at fryx.ch>

> I'll just trow that randomly in here.
>
> My gf told me that it would be nice if you could not only mark apps as
> favorites in kickoff, but also stuff like shutdown and especialy "lock
> computer". But i didn't look at the code to see how easely thats possible.
>
> Beat Wolf
>
> Am Samstag 22 Mai 2010, um 18.03:53 schrieb Alessandro Diaferia:
> > Hullo,
> > it seems reviewboard cannot connect to anonsvn (at least from here) so
> i'm
> > attaching the patch here as it is really small.
> >
> > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see
> > how easy is reproducing the bug.
> > It seems that kickoff does not allow adding favorites via D&D. D&D is
> only
> > used to move items in the list.
> > This little patch allows adding favorites via D&D dragging from the
> > application view to the favorites one.
> > I just don't know if this is considered as a new feature. It seems to me
> > that this patch just makes kickoff behaving as it is expected to behave.
> >
> > Anyway the last word is yours of course, plasma-friends :)
> >
> > Regards.
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>


It's not so immediate doing such a thing because what we have in the "Leave"
page are leave:/ protocol accessors.
So they're not properly local resources and therefore dragging is not
enableld for them.
Anyway what you suggest feels more like a feature so we should wait for KDE
4.6.
In addition to this probably a little "star" emblem appearing on hover for
each list item would be nice to make that favorite.
IIRC there was a discussion about this in the past.

Just talking about the fix are there any objections for it to be committed?
-- 
Alessandro Diaferia
KDE Developer
KDE e.V. member
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100523/68ef641b/attachment.htm