[PATCH] Fix kickof bug 231791 allowing apps dropping in the favorites view

[Alessandro Diaferia]

2010/5/22 Chani <chanika at gmail.com>

> On May 22, 2010 09:03:53 Alessandro Diaferia wrote:
> > Hullo,
> > it seems reviewboard cannot connect to anonsvn (at least from here) so
> i'm
> > attaching the patch here as it is really small.
> >
> > Having a look at https://bugs.kde.org/show_bug.cgi?id=231791 you can see
> > how easy is reproducing the bug.
> > It seems that kickoff does not allow adding favorites via D&D. D&D is
> only
> > used to move items in the list.
> > This little patch allows adding favorites via D&D dragging from the
> > application view to the favorites one.
> > I just don't know if this is considered as a new feature. It seems to me
> > that this patch just makes kickoff behaving as it is expected to behave.
> >
> > Anyway the last word is yours of course, plasma-friends :)
> >
> > Regards.
>
> hmm. no comment on whether it's a feature..  code looks sensible, although
> wouldn't it be more future-proof to iterate over data->urls() instead of
> only
> taking the first?
>

you're just right.. so here comes the updated patch :)


> --
> This message brought to you by eevil bananas and the number 3.
> www.chani3.com
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>


-- 
Alessandro Diaferia
KDE Developer
KDE e.V. member
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100523/b5c1c6b2/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kickoff_favs_latest.diff
Type: text/x-patch
Size: 2314 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20100523/b5c1c6b2/attachment.diff