<br><br><div class="gmail_quote">2010/5/22 Chani <span dir="ltr"><<a href="mailto:chanika@gmail.com">chanika@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><div></div><div class="h5">On May 22, 2010 09:03:53 Alessandro Diaferia wrote:<br>
> Hullo,<br>
> it seems reviewboard cannot connect to anonsvn (at least from here) so i'm<br>
> attaching the patch here as it is really small.<br>
><br>
> Having a look at <a href="https://bugs.kde.org/show_bug.cgi?id=231791" target="_blank">https://bugs.kde.org/show_bug.cgi?id=231791</a> you can see<br>
> how easy is reproducing the bug.<br>
> It seems that kickoff does not allow adding favorites via D&D. D&D is only<br>
> used to move items in the list.<br>
> This little patch allows adding favorites via D&D dragging from the<br>
> application view to the favorites one.<br>
> I just don't know if this is considered as a new feature. It seems to me<br>
> that this patch just makes kickoff behaving as it is expected to behave.<br>
><br>
> Anyway the last word is yours of course, plasma-friends :)<br>
><br>
> Regards.<br>
<br>
</div></div>hmm. no comment on whether it's a feature.. code looks sensible, although<br>
wouldn't it be more future-proof to iterate over data->urls() instead of only<br>
taking the first?<br></blockquote><div> </div><div>you're just right.. so here comes the updated patch :) <br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<font color="#888888"><br>
--<br>
This message brought to you by eevil bananas and the number 3.<br>
<a href="http://www.chani3.com" target="_blank">www.chani3.com</a><br>
</font><br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Alessandro Diaferia<br>KDE Developer<br>KDE e.V. member<br><br>