[patch] Fix network monitor colors and stacking
Aaron J. Seigo
aseigo at kde.org
Tue May 18 01:58:09 CEST 2010
hi Sergey ...
On May 17, 2010, Sergey wrote:
> Problem:
> It's very hard to understand on the network monitor plasmoid which
> line is download and which is upload speed. They also stack and
> this is not really usual for this kind of graphs.
thanks for the patch; i'll let the system monitor developer(s) decie on how to
merge this patch, but here are my comments:
* using hardcoded colors isn't going to work with all themes; this needs to
use the Plasma::Theme colors in the some way, even if it means expsing more of
the colors in the color scheme to do so
* i'd probably overload setPlotCount into setPlotCount(int count) and
setPlotCount(const QList<QColor> &) .. the latter is a bit odd looking, but it
will result in cleaner code than setPlotCount(int, const QList<QColor> &).
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20100517/f06194cb/attachment.sig
More information about the Plasma-devel
mailing list