Review Request: Initial work on the flexible controller of the Plasma Media Center

Marco Martin notmart at gmail.com
Fri Mar 26 18:41:15 CET 2010


On Friday 26 March 2010, Shantanu Tushar Jha wrote:
> >     So what I suggest is to keep modes for playing, and let a plugin add
> >     a new mode, just like we add a new wallpaper plugin in Plasma, for
> >     example. Then we can have another plugin for, say, Games as you said
> >     in the previous post.
> 
> Hi Marco,
> I, Alessandro and Christophe had a discussion on IRC over this, and I'd
> like to summarize what we discussed and the conclusions we made -
> 
> * The general use case for a media center is mode specific (and keeps the
> workflow organized), so we keep the modes idea, but one which will be 
> flexible. * For example, the Pictures mode will be a File Browser plugin
> which displays the Pictures, we can have similar plugins for local videos,
> youtube videos, a music plugin which organizes files into Artists, Albums
> etc * Regarding what you said, we concluded that we might have a "All
> Media" mode in which all media can be browsed. In this way, we can
> continue to implement the mimetype approach you were talking about. * In
> general, the plugin-for-mode approach will allow community written modes
> which one can download from, say kde-look.org and plug into the MC. This
> will be a great experience :)
> 
> Please feel free to comment in case we didn't get you properly, or you've
> some suggestions :)

ok, i basically agree on all the above points.
i hope to be able to come online later today to still discuss this a bit.
in the meantime the current patch could be a good start, it can be refined and 
generalized in a second moment :)

Cheers,
Marco Martin

> 
> - Shantanu
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3396/#review4684
> -----------------------------------------------------------
> 
> On 2010-03-25 19:01:32, Christophe Olinger wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3396/
> > -----------------------------------------------------------
> > 
> > (Updated 2010-03-25 19:01:32)
> > 
> > 
> > Review request for Plasma.
> > 
> > 
> > Summary
> > -------
> > 
> > This patch extends the controller applet by having 6 different layout
> > modes which are adapted to what the media center is currently used for,
> > i.e. browsing pictures, playing videos, etc. It sends a signal to the
> > containment with the current mode. The containment then relayouts the
> > other applets and configures them for the current Mode. These modes are
> > defined as enum in the libs. *The browser no longer has any controls.
> > Those are now in the controller. *The controller also has a show/hide
> > playlist button and a toggle autohide button for itself. *The different
> > modes do not have sensible functions yet. I also need to work on
> > configuring the applets for each mode, like telling the browser to hide,
> > or the player to show. *The controller is not really beautiful. I want
> > animations for show(hide icons. I want the modeswitch button in a
> > "drawer" perhaps. The toggle buttons need effects.
> > 
> > 
> > Diffs
> > -----
> > 
> >   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrowse
> >   r/abstractmediaitemview.cpp 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrows
> >   er/mediabrowser.h 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediabrows
> >   er/mediabrowser.cpp 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontr
> >   oller/controller.h 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontr
> >   oller/controller.cpp 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/containments/media
> >   containment/mediacontainment.h 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/containments/media
> >   containment/mediacontainment.cpp 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/containments/media
> >   containment/medialayout.h 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/containments/media
> >   containment/medialayout.cpp 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/b
> >   rowser.cpp 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/m
> >   ediacenter.h 1107457
> >   /trunk/playground/base/plasma/MediaCenterComponents/shells/plasmediace
> >   nter/mainwindow.cpp 1107457
> > 
> > Diff: http://reviewboard.kde.org/r/3396/diff
> > 
> > 
> > Testing
> > -------
> > 
> > I tested the controller itself. The actual effect on the other applets
> > when changing modes still needs work.
> > 
> > 
> > Thanks,
> > 
> > Christophe




More information about the Plasma-devel mailing list