Review Request: Patch to use the data engine for status notifier items

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3265/#review4484
-----------------------------------------------------------

Ship it!


as i said on the other patch even if is not perfect it should go in asap (with asap being waiting for the Aurelien patch to be committed) otherwise the patch becomes really too big.
Just by quicly reading at the èatch i can't tell: can you quantify exactly what is still missing?


/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp
<http://reviewboard.kde.org/r/3265/#comment3943>

    my concern about using dataengines this way is that is not possible to use them in remote applets,
    but is a limitation of the remote applets machinery i guess


- Marco


On 2010-03-11 21:36:46, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3265/
> -----------------------------------------------------------
> 
> (Updated 2010-03-11 21:36:46)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Preliminary patch to use the data engine for status notifier items instead of directly the dbus protocol.
> This patch is only a preliminary version to get some early feedback. More work is actually needed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/CMakeLists.txt 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.cpp 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.desktop 1101760 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.h 1101760 
> 
> Diff: http://reviewboard.kde.org/r/3265/diff
> 
> 
> Testing
> -------
> 
> Kinda works. Tested in a kde 4.4 session. Even if the port is not complete, the applet is till functionnal.
> 
> 
> Thanks,
> 
> Matthieu
> 
>