Review Request: Patch to use the data engine for status notifier items

Matthieu Gallien matthieu_gallien at yahoo.fr
Thu Mar 11 22:36:46 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3265/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Preliminary patch to use the data engine for status notifier items instead of directly the dbus protocol.
This patch is only a preliminary version to get some early feedback. More work is actually needed.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/CMakeLists.txt 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.cpp 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.desktop 1101760 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.h 1101760 

Diff: http://reviewboard.kde.org/r/3265/diff


Testing
-------

Kinda works. Tested in a kde 4.4 session. Even if the port is not complete, the applet is till functionnal.


Thanks,

Matthieu



More information about the Plasma-devel mailing list