Review Request: frame plasmoid: image load and scaling with threads
Aaron J. Seigo
aseigo at kde.org
Mon Mar 8 23:16:07 CET 2010
On March 8, 2010, Sebastian Kügler wrote:
> On Monday 08 March 2010 19:50:42 Aaron Seigo wrote:
> > as far as i can see, the loader is never deleted. it emits its
> > signal,
> >
> > pictureLoaded is called, and then the object is dropped and just sits
> > there in memory.
>
> As far as I can see, it sits there to hold the image at its original size,
> which is needed for rescaling correctly (no need to store it at full size
> though, as I said, screen reso with some fallback loading is probably good
> enough).
possible alternative solution:
screen resolution is even too much. perhaps store it at some multiple of the
displayed size (qMin(1.5*size, screenSize)) so that small rescales are fast
and beautiful. when making it bigger, wait a period of time (to avoid constant
resampling due to resizing) and resample the image. yes, this means that if it
is resized more than 1.5 (or whatever factor) times larger than the current
size it will get upscaled and look blocky until the resampling is complete.
this would give a nice compromise between memory usage, resize speed and how
good it looks while resizing.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
More information about the Plasma-devel
mailing list