Review Request: Some system tray fixes

[Andreas Hartmetz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3165/
-----------------------------------------------------------

(Updated 2010-03-07 00:01:49.016030)


Review request for Plasma.


Changes
-------

The description of bug 228655 (yes, I wrote it :) seems to fit.


Summary
-------

The system tray behaves very erratically here, depending on exact circumstances (compositing or not, some apparently random factors) so I looked into the code a bit.
First I removed a very ugly hack that apparently fixed a bug that could be fixed otherwise, this is why I'm posting this to reviewboard. That part is the last hunk.
After doing that plasma-desktop crashed a lot, so I fixed the obviously dangerous (the way non-POD statics are) to outright incorrect (deleting and never recreating the background thingie) usage of class-statics, too.


This addresses bug 228655.
    https://bugs.kde.org/show_bug.cgi?id=228655


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp 1100150 

Diff: http://reviewboard.kde.org/r/3165/diff


Testing
-------

Not much yet, less than an hour of use - no crashes so far. No erratic behavior either.


Thanks,

Andreas