Review Request: Update WebShortcutRunner to handle complex substitutions

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4490/#review6318
-----------------------------------------------------------

Ship it!


a couple of minor ws issues, but the actual code is the right direction. this entire plugin needs to be ported to KUriFilter now that it has support in 4.5 for all the things the krunner plugin requires. this is a good start to that. please commit to trunk and backport to the 4.5 branch. (holler if you need a hand with the latter)


/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp
<http://reviewboard.kde.org/r/4490/#comment6048>

    no spaces inside of ()s.



/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp
<http://reviewboard.kde.org/r/4490/#comment6047>

    ()s around the return statement are not necessary


- Aaron


On 2010-06-28 20:27:24, Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4490/
> -----------------------------------------------------------
> 
> (Updated 2010-06-28 20:27:24)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch updates the web shortcuts runner so that it can handle substitutions other than the basic \\{@}.  Some of the web shortcuts provided with kdebase - e.g. cpan, docbook, google_code - use \\{number} substitutions.
> 
> This is done by replacing the body of WebshortcutRunner::searchQuery() to simply call the kurisearchfilter URI filter.
> 
> 
> This addresses bug 242156.
>     https://bugs.kde.org/show_bug.cgi?id=242156
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp 1139171 
> 
> Diff: http://reviewboard.kde.org/r/4490/diff
> 
> 
> Testing
> -------
> 
> Checked KRunner with patch applied, all web shortcuts are handled correctly.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100629/c8168de5/attachment.htm