Review Request: Update WebShortcutRunner to handle complex substitutions
Jonathan Marten
jjm at keelhaul.me.uk
Mon Jun 28 22:27:24 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4490/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
This patch updates the web shortcuts runner so that it can handle substitutions other than the basic \\{@}. Some of the web shortcuts provided with kdebase - e.g. cpan, docbook, google_code - use \\{number} substitutions.
This is done by replacing the body of WebshortcutRunner::searchQuery() to simply call the kurisearchfilter URI filter.
This addresses bug 242156.
https://bugs.kde.org/show_bug.cgi?id=242156
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/generic/runners/webshortcuts/webshortcutrunner.cpp 1139171
Diff: http://reviewboard.kde.org/r/4490/diff
Testing
-------
Checked KRunner with patch applied, all web shortcuts are handled correctly.
Thanks,
Jonathan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100628/d26479d1/attachment.htm
More information about the Plasma-devel
mailing list