Review Request: fix data leak in dataengines

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4261/#review6044
-----------------------------------------------------------

Ship it!


should work.
is this new api necessary?

- Marco


On 2010-06-08 20:30:26, Beat Wolf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4261/
> -----------------------------------------------------------
> 
> (Updated 2010-06-08 20:30:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> fix the data "leak" introduced by http://reviewboard.kde.org/r/4235/
> The fix is to use insertMulti if multiple values with the same key are added at once.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/datacontainer.h 1136034 
>   trunk/KDE/kdelibs/plasma/datacontainer.cpp 1135137 
>   trunk/KDE/kdelibs/plasma/dataengine.cpp 1135137 
> 
> Diff: http://reviewboard.kde.org/r/4261/diff
> 
> 
> Testing
> -------
> 
> Different plasmoids using dataengines
> 
> 
> Thanks,
> 
> Beat
> 
>