Review Request: fix data leak in dataengines

Beat Wolf asraniel at fryx.ch
Tue Jun 8 22:30:26 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4261/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

fix the data "leak" introduced by http://reviewboard.kde.org/r/4235/
The fix is to use insertMulti if multiple values with the same key are added at once.


Diffs
-----

  trunk/KDE/kdelibs/plasma/datacontainer.h 1136034 
  trunk/KDE/kdelibs/plasma/datacontainer.cpp 1135137 
  trunk/KDE/kdelibs/plasma/dataengine.cpp 1135137 

Diff: http://reviewboard.kde.org/r/4261/diff


Testing
-------

Different plasmoids using dataengines


Thanks,

Beat



More information about the Plasma-devel mailing list