Review Request: Plasma-Mediacenter: Cosmetics for the playlist

Christophe Olinger olingerc at binarylooks.com
Wed Jun 2 18:48:51 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4167/
-----------------------------------------------------------

(Updated 2010-06-02 16:48:51.702331)


Review request for Plasma and Alessandro Diaferia.


Changes
-------

Since I do the apinting of the plalyist myself, the backgroundHints check used to get the correct svg of the background was useless. I now Set backgroundHints to noBackground and use the standard widgets/background to resize the playlist correctly


Summary
-------

This (for once very small) patch stretches the playlist fully between the two horizontal bars and makes it a bit wider. It also gives us the ability to theme the playlist.
Actually it looks best without any background when the use is browsing things, but a background would be needed when a video is playing and the playlist is shown.
What do ya think?

Bug: The playlist handler does not correctly follow the resizing of the playlist


Diffs (updated)
-----

  trunk/playground/base/plasma/MediaCenterComponents/applets/mediacontroller/controller.cpp 1133387 
  trunk/playground/base/plasma/MediaCenterComponents/applets/mediainfobar/mediainfobar.cpp 1133387 
  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistapplet.h 1133387 
  trunk/playground/base/plasma/MediaCenterComponents/applets/playlist/playlistapplet.cpp 1133387 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.h 1133387 
  trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/medialayout.cpp 1133387 

Diff: http://reviewboard.kde.org/r/4167/diff


Testing
-------


Thanks,

Christophe



More information about the Plasma-devel mailing list