Review Request: transient extenderitems

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4758/#review6694
-----------------------------------------------------------

Ship it!


neat hack; you should probably add some code comments explaining what is going on in the .cpp file as it isn't clear on first glance. otherwise, with the one comment below address, ship it. :)


/trunk/KDE/kdelibs/plasma/extenders/extenderitem.h
<http://reviewboard.kde.org/r/4758/#comment6474>

    needs apidox and a const getter


- Aaron


On 2010-07-23 18:05:03, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4758/
> -----------------------------------------------------------
> 
> (Updated 2010-07-23 18:05:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> another of those things that doesn't feel right, but feels that current use cases kinda requires something like that:
> 
> dd an option in extenderitem to use a config group completely in memory, intended for extenderitems that really aren't supposed to be saved and restored on disk.
> the notifications one, but more important the job ones really don't have a big point to be saved.
> at the moment they are cleaned out at exit, but sometimes stay in the config file after a plasma crash
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/extenders/extenderitem.h 1153063 
>   /trunk/KDE/kdelibs/plasma/extenders/extenderitem.cpp 1153063 
> 
> Diff: http://reviewboard.kde.org/r/4758/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100723/2dda6494/attachment.htm