Review Request: Use Plasma::ScrollWidget in the widget explorer

[Aaron Seigo]

> On 2010-07-19 21:33:59, Aaron Seigo wrote:
> > i love the amount of red in this one :)
> > 
> > only comment i have is that if the close button were moved into FilteringWidget itself, and a "closeClicked()" signal added to it, then the somewhat nasty static_cast to assign filteringLayout could be removed and all of that code could be encapsulated in FilteringWidget. with that done, i think this should go into svn :)
> 
> Aurélien Gâteau wrote:
>     I can move the close button inside FilteringWidget, but that would mean that in vertical orientation the close button would move from the bottom-left corner to the top-right. If we do this we should move the close button of the panel which contains the "Add Widgets..." button as well, for consistency.

i think moving the button to the top right in vertical would be a good move, regardless. as you pointed out the other week @ akademy, it would free up more vertical space and would be more consistent in general.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4676/#review6644
-----------------------------------------------------------


On 2010-07-17 23:05:49, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4676/
> -----------------------------------------------------------
> 
> (Updated 2010-07-17 23:05:49)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on plasma-devel.
> 
> The horizontal orientation behaved a bit strangely: AbstractIconList was becoming much larger than the screen width. I had to change the layout code to include the "Close" button inside FilteringWidget layout instead of creating another layout.
> 
> Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider sizes.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h 1147944 
>   trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp 1147944 
>   trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h 1147944 
>   trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp 1147944 
>   trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 1147944 
> 
> Diff: http://reviewboard.kde.org/r/4676/diff
> 
> 
> Testing
> -------
> 
> Tested in both horizontal and vertical modes, with lists larger and smaller than the view.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100720/410f0873/attachment.htm