<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4676/">http://reviewboard.kde.org/r/4676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 19th, 2010, 9:33 p.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>i love the amount of red in this one :)
only comment i have is that if the close button were moved into FilteringWidget itself, and a "closeClicked()" signal added to it, then the somewhat nasty static_cast to assign filteringLayout could be removed and all of that code could be encapsulated in FilteringWidget. with that done, i think this should go into svn :)</pre>
</blockquote>
<p>On July 20th, 2010, 8:14 a.m., <b>Aurélien Gâteau</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre>I can move the close button inside FilteringWidget, but that would mean that in vertical orientation the close button would move from the bottom-left corner to the top-right. If we do this we should move the close button of the panel which contains the "Add Widgets..." button as well, for consistency.</pre>
</blockquote>
</blockquote>
<pre>i think moving the button to the top right in vertical would be a good move, regardless. as you pointed out the other week @ akademy, it would free up more vertical space and would be more consistent in general.</pre>
<br />
<p>- Aaron</p>
<br />
<p>On July 17th, 2010, 11:05 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated 2010-07-17 23:05:49</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Make AbstractIconList inherit from Plasma::ScrollWidget, has discussed on plasma-devel.
The horizontal orientation behaved a bit strangely: AbstractIconList was becoming much larger than the screen width. I had to change the layout code to include the "Close" button inside FilteringWidget layout instead of creating another layout.
Note: you need http://reviewboard.kde.org/r/4675/ to get proper scrollbar slider sizes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Tested in both horizontal and vertical modes, with lists larger and smaller than the view.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.h <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/abstracticonlist.cpp <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.h <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletslist.cpp <span style="color: grey">(1147944)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp <span style="color: grey">(1147944)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4676/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>