Review Request: Relayout painting code of systemtray for better readability

[Manuel Mommertz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4645/#review6591
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp
<http://reviewboard.kde.org/r/4645/#comment6342>

    Bug 1: used leftEasement where rightEasement is the one we want



/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp
<http://reviewboard.kde.org/r/4645/#comment6343>

    Bug 2: If the widget it vertical but the theme does not provide a horizontal seperator it goes to painting a vertical one with code for horizontal formfactor... definitly not what we want


- Manuel


On 2010-07-15 14:39:18, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4645/
> -----------------------------------------------------------
> 
> (Updated 2010-07-15 14:39:18)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch mainly moves lines around so it is easier to read (in my opinion). While doing this I found two little bugs that are solved in this. Of cause if you don't like this relayout I will fix the bugs separately.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1150203 
> 
> Diff: http://reviewboard.kde.org/r/4645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100715/5955abe2/attachment-0001.htm