Review Request: Relayout painting code of systemtray for better readability

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4645/#review6590
-----------------------------------------------------------

Ship it!


the code is more readable imho after your changes. nice :)

what, btw, were the small bugs that were fixed?

i did notice that the clipping isn't always turned on in the painter; that was previously avoided if possible since clipping adds a bunch more operations on the painting. whether or not this creates a meaningful difference is something that ought to be measured. before committing, please put a TODO note above the clip rect line noting that the impact of always setting the clip rect should be measured to ensure that it is negligible enough not to worry about.

- Aaron


On 2010-07-15 14:39:18, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4645/
> -----------------------------------------------------------
> 
> (Updated 2010-07-15 14:39:18)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch mainly moves lines around so it is easier to read (in my opinion). While doing this I found two little bugs that are solved in this. Of cause if you don't like this relayout I will fix the bugs separately.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1150203 
> 
> Diff: http://reviewboard.kde.org/r/4645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100715/6905e742/attachment-0001.htm