Review Request: Fixing painting of systemtray

[Aaron Seigo]

> On 2010-07-14 17:39:58, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp, lines 322-325
> > <http://reviewboard.kde.org/r/4623/diff/3/?file=31168#file31168line322>
> >
> >     these kinds of changes are really annoying. yes, rightEasement isn't used right now. but what if we do use it in the future? then we'll have to add this code back in.
> >     
> >     is the code that was removed a performance problem? no.
> >     
> >     was it unreadable? no.
> >     
> >     so why was it removed? just because.
> >     
> >     at one point, it ONLY supported rightEasement. when we had need for leftEasement, and switched over to that, both left and right easement calculation was kept so that we could easily change the right/left layout decisions later on down the road. now we're back to having an assumption in the code that we only have some special space on the left.
> >     
> >     please put the rightEasement code back in ASAP.
> 
> Manuel Mommertz wrote:
>     I discussed this with notmart already. The code isn't used at the moment and notmart said it will not be used in the future. So removed it as the calucaltions where wrong and why correct a not used code?. For the planed rewrite for 4.6 I can reintroduce this in a clean way. No Problem.
>     But as we are on this, one question: Should there be a seperator in case right easment is used? I would do it, as the background would change to (if the theme has one...)

> The code isn't used at the moment and notmart said it will not be used in the future.

that's what we thought about the left easement prior to 4.5 ;)

> Should there be a seperator in case right easment is used?

i agree with Marco here: i don't think it's necessary since if the right easement gets used, there is no reason to currently assume it will serve the same purpose that we are using the icons to the left for.

looking forward to what you come up with in 4.6 :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/#review6561
-----------------------------------------------------------


On 2010-07-15 10:41:09, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4623/
> -----------------------------------------------------------
> 
> (Updated 2010-07-15 10:41:09)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Correct drawing code in systemtray.
> don't use rect() anymore as this rect doesn't contain borders in planar more and leads to drawing errors there. setting to same size as contentsRect.
> Right easment is currently not used and therefore removed from calculation.
> Qt::IntersectClip doesn't make sense here as this clips away the background for firstelements.
> 
> For 4.6 I would completly rewrite the drawing code for better reading. But to not introduce new bugs in 4.5 in this late phase I want to get this patch for now.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1149766 
> 
> Diff: http://reviewboard.kde.org/r/4623/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> systray in floating layout. bottom with patch applied
>   http://reviewboard.kde.org/r/4623/s/458/
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100715/ded9ee91/attachment.htm