Review Request: Fixing painting of systemtray

Manuel Mommertz 2kmm at gmx.de
Tue Jul 13 20:44:45 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Correct drawing code in systemtray.
don't use rect() anymore as this rect doesn't contain borders in planar more and leads to drawing errors there. setting to same size as contentsRect.
Right easment is currently not used and therefore removed from calculation.
Qt::IntersectClip doesn't make sense here as this clips away the background for firstelements.

For 4.6 I would completly rewrite the drawing code for better reading. But to not introduce new bugs in 4.5 in this late phase I want to get this patch for now.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1148491 

Diff: http://reviewboard.kde.org/r/4623/diff


Testing
-------


Screenshots
-----------

systray in floating layout. bottom with patch applied
  http://reviewboard.kde.org/r/4623/s/458/


Thanks,

Manuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100713/077cc89e/attachment.htm 


More information about the Plasma-devel mailing list