Review Request: Fixing painting of systemtray

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4623/#review6538
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp
<http://reviewboard.kde.org/r/4623/#comment6280>

    Qt::IntersectClip is needed in the case the systray would be in a clipped area eg in an item with the flag itemclipschildrentorect (e.g. the newspaper containment, or whatever containment that will have this charateristic)
    otherwise the systray backgrond would bleed outside the clipped area instead of being cut


- Marco


On 2010-07-13 18:44:45, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4623/
> -----------------------------------------------------------
> 
> (Updated 2010-07-13 18:44:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Correct drawing code in systemtray.
> don't use rect() anymore as this rect doesn't contain borders in planar more and leads to drawing errors there. setting to same size as contentsRect.
> Right easment is currently not used and therefore removed from calculation.
> Qt::IntersectClip doesn't make sense here as this clips away the background for firstelements.
> 
> For 4.6 I would completly rewrite the drawing code for better reading. But to not introduce new bugs in 4.5 in this late phase I want to get this patch for now.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/applet.cpp 1148491 
> 
> Diff: http://reviewboard.kde.org/r/4623/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> systray in floating layout. bottom with patch applied
>   http://reviewboard.kde.org/r/4623/s/458/
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100713/e98e77cb/attachment.htm