Review Request: Add external loader support to Plasma::Applet, Plasma::DataEngine, Plasma::Service

[Ryan Rix]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4554/
-----------------------------------------------------------

(Updated 2010-07-11 16:57:12.494120)


Review request for Plasma, Aaron Seigo and Shaun Reich.


Changes
-------

Changes per aseigo's comments


Summary
-------

Adds ability for applications which embed plasma to specify a class which plasma will query for Applet, DataEngine, and Service creation, giving them the chance to create these objects internally.

The foremost use of this is to give Plasma the chance to ask applications when restoring layouts from disk, for applets which were based on QWidgets, such as the case in various Plasma dashboards which may embed QWidgets as plasma::applets ....


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/CMakeLists.txt 1146180 
  trunk/KDE/kdelibs/plasma/applet.cpp 1146180 
  trunk/KDE/kdelibs/plasma/dataenginemanager.cpp 1146180 
  trunk/KDE/kdelibs/plasma/externalpluginloader.h PRE-CREATION 
  trunk/KDE/kdelibs/plasma/externalpluginloader.cpp PRE-CREATION 
  trunk/KDE/kdelibs/plasma/service.cpp 1146180 

Diff: http://reviewboard.kde.org/r/4554/diff


Testing
-------

Well, this thing is about 90% there right now, everything works, etc, afaict, but I can't get the instance of the PluginManager outside of the Plasma namespace, if someone could help that would be great. :) I can commit some support into trunk/playground/base/shells/kpart 


Thanks,

Ryan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100711/f7c9f643/attachment.htm