<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4554/">http://reviewboard.kde.org/r/4554/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron Seigo and Shaun Reich.</div>
<div>By Ryan Rix.</div>
<p style="color: grey;"><i>Updated 2010-07-11 16:57:12.494120</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Changes per aseigo's comments</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Adds ability for applications which embed plasma to specify a class which plasma will query for Applet, DataEngine, and Service creation, giving them the chance to create these objects internally.
The foremost use of this is to give Plasma the chance to ask applications when restoring layouts from disk, for applets which were based on QWidgets, such as the case in various Plasma dashboards which may embed QWidgets as plasma::applets ....</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Well, this thing is about 90% there right now, everything works, etc, afaict, but I can't get the instance of the PluginManager outside of the Plasma namespace, if someone could help that would be great. :) I can commit some support into trunk/playground/base/shells/kpart </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdelibs/plasma/CMakeLists.txt <span style="color: grey">(1146180)</span></li>
<li>trunk/KDE/kdelibs/plasma/applet.cpp <span style="color: grey">(1146180)</span></li>
<li>trunk/KDE/kdelibs/plasma/dataenginemanager.cpp <span style="color: grey">(1146180)</span></li>
<li>trunk/KDE/kdelibs/plasma/externalpluginloader.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/externalpluginloader.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdelibs/plasma/service.cpp <span style="color: grey">(1146180)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>