Review Request: Adds support for corner widgets in Plasma::TabBar

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/#review6466
-----------------------------------------------------------



trunk/KDE/kdelibs/plasma/widgets/tabbar.h
<http://reviewboard.kde.org/r/4537/#comment6206>

    @since 4.6



trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp
<http://reviewboard.kde.org/r/4537/#comment6208>

    external users are going to keep a pointer of this, so use a QWeakPointer



trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp
<http://reviewboard.kde.org/r/4537/#comment6207>

    should change the widget ownership to TabBar and delete any old one that was already existing


- Marco


On 2010-07-10 14:26:41, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4537/
> -----------------------------------------------------------
> 
> (Updated 2010-07-10 14:26:41)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
>   trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 
> 
> Diff: http://reviewboard.kde.org/r/4537/diff
> 
> 
> Testing
> -------
> 
> Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly.
> 
> 
> Screenshots
> -----------
> 
> added two Plasma::PushButton
>   http://reviewboard.kde.org/r/4537/s/446/
> 
> 
> Thanks,
> 
> Giulio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100710/08fa29bb/attachment.htm