Review Request: Adds support for corner widgets in Plasma::TabBar

Giulio Camuffo giuliocamuffo at gmail.com
Sat Jul 10 16:26:41 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4537/
-----------------------------------------------------------

(Updated 2010-07-10 14:26:41.506304)


Review request for Plasma and Marco Martin.


Changes
-------

Modified the methods: setFirstPositionWidget and setLastPositionWidget.
Take care of the layoutDirection.


Summary
-------

This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget.


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 
  trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 

Diff: http://reviewboard.kde.org/r/4537/diff


Testing
-------

Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly.


Screenshots
-----------

added two Plasma::PushButton
  http://reviewboard.kde.org/r/4537/s/446/


Thanks,

Giulio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100710/78f75400/attachment.htm 


More information about the Plasma-devel mailing list