Review Request: Imgur support in Pastebin applet

[Sebastian Kügler]

On Tuesday 26 January 2010 18:17:48 Nikhil Marathe wrote:
> > On 2010-01-26 10:44:10, Sebastian Kügler wrote:
> > > trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp,
> > > line 79
> > > <http://reviewboard.kde.org/r/2324/diff/2/?file=17781#file17781line79>
> > > 
> > >     Did you also copy the FlickR Kipi plugin's copyright? If you copy
> > >     code, you also need to take the copyright.
> 
> I'm relatively new to KDE dev and never had to copy code before, so I
> didn't know that. Do you mean that I should copy the name/email of the
> original authors and put it in the new file. Actually this code is copied
> from the imageshack.cpp code where it says '// taken from flickr KIPI
> plugin'

Yes, the code you copy is still copyrighted by the original author, the license 
allows you to copy it (but you have to include the author's copyright as well).

> > On 2010-01-26 10:44:10, Sebastian Kügler wrote:
> > > trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp,
> > > line 162
> > > <http://reviewboard.kde.org/r/2324/diff/2/?file=17781#file17781line162
> > > >
> > > 
> > >     How does this work? Everybody using KDE will use Shantanu's key?
> > >     
> > >     It might be a good idea to ask Imgur what they want to do with
> > >     this.
> 
> I've written to Alan at Imgur, awaiting his reply

Cool, thanks!

> > On 2010-01-26 10:44:10, Sebastian Kügler wrote:
> > > trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.h, line
> > > 32
> > > <http://reviewboard.kde.org/r/2324/diff/2/?file=17780#file17780line32>
> > > 
> > >     Left-over? :)
> 
> my bad. Will commit changes in a few hours

No biggie, that's why we do reviews. :)
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9