Review Request: Imgur support in Pastebin applet

[Nikhil Marathe]

> On 2010-01-26 10:44:10, Sebastian Kügler wrote:
> > trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp, line 79
> > <http://reviewboard.kde.org/r/2324/diff/2/?file=17781#file17781line79>
> >
> >     Did you also copy the FlickR Kipi plugin's copyright? If you copy code, you also need to take the copyright.

I'm relatively new to KDE dev and never had to copy code before, so I didn't know that. Do you mean that I should copy the name/email of the original authors and put it in the new file. Actually this code is copied from the imageshack.cpp code where it says '// taken from flickr KIPI plugin'


> On 2010-01-26 10:44:10, Sebastian Kügler wrote:
> > trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp, line 162
> > <http://reviewboard.kde.org/r/2324/diff/2/?file=17781#file17781line162>
> >
> >     How does this work? Everybody using KDE will use Shantanu's key?
> >     
> >     It might be a good idea to ask Imgur what they want to do with this.

I've written to Alan at Imgur, awaiting his reply


> On 2010-01-26 10:44:10, Sebastian Kügler wrote:
> > trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.h, line 32
> > <http://reviewboard.kde.org/r/2324/diff/2/?file=17780#file17780line32>
> >
> >     Left-over? :)

my bad. Will commit changes in a few hours


- Nikhil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2324/#review3895
-----------------------------------------------------------


On 2010-01-26 04:29:10, Nikhil Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2324/
> -----------------------------------------------------------
> 
> (Updated 2010-01-26 04:29:10)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> A patch to add support for uploading images to imgur.com for the Pastebin applet.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1079836 
>   trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1079836 
>   trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/CMakeLists.txt 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/backends.h 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.h PRE-CREATION 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/backends/imgur.cpp PRE-CREATION 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/pastebinservice.h 1079836 
>   trunk/KDE/kdeplasma-addons/dataengines/pastebin/pastebinservice.cpp 1079836 
> 
> Diff: http://reviewboard.kde.org/r/2324/diff
> 
> 
> Testing
> -------
> 
> Tried on current trunk, works fine.
> 
> 
> Thanks,
> 
> Nikhil
> 
>