Review Request: Update the method name in gps library

[Pino Toscano]

> On 2010-01-04 23:20:09, Aaron Seigo wrote:
> > deja vu; we had a patch recently that did something similar, except it tried some ifdef's. see:
> > 
> > http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp?r1=1023511&r2=1065343
> > 
> > but that was reverted with this:
> > 
> > http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp?r1=1065343&r2=1065667
> > 
> > is the api in 2.9 different from 3.x as well then? or is 2.9 just the name for "3.x pre-releases"? in any case, i'd much prefer to see an ifdef so it continues to build with both versions if possible since there are many (very recent, event) distros that are shipping libgps 2.3.x

Note Marble uses gpsd as well (in its geolocation plugin): might be worth doing the same multiversion #ifdef'ing.


- Pino


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2493/#review3576
-----------------------------------------------------------


On 2010-01-04 21:46:43, loureiro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2493/
> -----------------------------------------------------------
> 
> (Updated 2010-01-04 21:46:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The current version of gps library is 2.90 and the version used in geolocation is 2.39 and when I try get compile kdebase I get error about gps_query method, so I lookup into the gps library and that method doesn't exists that was replaced to gps_send, well this is a simple patch that updates to the new method name.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/dataengines/geolocation/location_gps.cpp 1070090 
> 
> Diff: http://reviewboard.kde.org/r/2493/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> loureiro
> 
>