Review Request: Updated Kimpanel plasmoid animation to use Plasma::Animator::FadeAnimation
Marco Martin
notmart at gmail.com
Tue Feb 16 00:05:14 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2941/#review4170
-----------------------------------------------------------
Ship it!
don't know kimpanel very much, but the patch seems sensible
- Marco
On 2010-02-15 14:26:06, Bruno Abinader wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2941/
> -----------------------------------------------------------
>
> (Updated 2010-02-15 14:26:06)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Replaced the deprecated animation API with Plasma::Animator::FadeAnimation. Actually in this case the animation code was commented and old, I've updated it using the new animation API (Plasma::Animator::FadeAnimation) and now it works like a charm ;)
>
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/kimpanel/src/kimlabelgraphics.h 1090523
> trunk/KDE/kdeplasma-addons/applets/kimpanel/src/kimlabelgraphics.cpp 1090523
>
> Diff: http://reviewboard.kde.org/r/2941/diff
>
>
> Testing
> -------
>
> After compile + install, the plasmoid gets its inner widget highlighted when the mouse hovers in and out of it.
>
>
> Thanks,
>
> Bruno
>
>
More information about the Plasma-devel
mailing list