Review Request: Fix segv in newspaper AppletTitleBar and use QParallelAnimationGroup to anime conf and close button
Marco Martin
notmart at gmail.com
Tue Feb 9 22:47:20 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2862/#review4114
-----------------------------------------------------------
Ship it!
good to go :)
- Marco
On 2010-02-09 21:43:03, loureiro wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2862/
> -----------------------------------------------------------
>
> (Updated 2010-02-09 21:43:03)
>
>
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, Adenilson Cavalcanti, and Bruno Abinader.
>
>
> Summary
> -------
>
> Fix segv in AppletTitleBar class and use QPixmapTransitionAnimation to configure and close button to plasma-netbook.
> This patch fix some issues, now I use QParellelAnimationGroup to both animations buttons.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/applettitlebar.h 1087934
> trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/applettitlebar.cpp 1087934
>
> Diff: http://reviewboard.kde.org/r/2862/diff
>
>
> Testing
> -------
>
> I've compile and run plasma-netbook, everything runs fine to me, but in HoverLeave event I noticed a weird behaviour in Animatio::PixmapTransition.
>
>
> Thanks,
>
> loureiro
>
>
More information about the Plasma-devel
mailing list