Review Request: plasma (PackageStructurePrivate::createPackageMetadata) : make a kWarning be usefull again

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6185/#review9372
-----------------------------------------------------------

Ship it!


good catches, thanks :)

- Aaron


On 2010-12-22 14:08:04, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6185/
> -----------------------------------------------------------
> 
> (Updated 2010-12-22 14:08:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> in PackageStructurePrivate::createPackageMetadata there is a kWarning which is useless because the stream to show is cleared just before the kWarning.
> This small patch fixes this issue.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/packagestructure.cpp 1208544 
> 
> Diff: http://svn.reviewboard.kde.org/r/6185/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101222/354f1a9e/attachment.htm