Review Request: Replace slow foreach constructs with faster ones

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6110/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Doing 
foreach (const QString &k, elements.keys()) {
        stylesheet.replace(k, elements[k]);
}
Is slower and more memory intensive than needed. Chanegd to better constructs.


Diffs
-----

  /trunk/KDE/kdelibs/plasma/datacontainer.cpp 1206096 
  /trunk/KDE/kdelibs/plasma/private/serviceprovider.cpp 1206096 
  /trunk/KDE/kdelibs/plasma/theme.cpp 1206096 

Diff: http://svn.reviewboard.kde.org/r/6110/diff


Testing
-------

None


Thanks,

Albert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101213/3571311a/attachment.htm