Review Request: Plasma crash if lockout conf file is malformed.

Marco Martin notmart at gmail.com
Sun Dec 5 23:40:41 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6060/#review9146
-----------------------------------------------------------

Ship it!


makes sense to me (it's not doing anymore what te config says, but the cofig is saying actually to make a broken applet)

- Marco


On 2010-12-05 22:36:32, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6060/
> -----------------------------------------------------------
> 
> (Updated 2010-12-05 22:36:32)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> if on the plasma conf file we have for the lockout plasmoid :
> 
> showHibernateButton=false
> showLockButton=false
> showLogoutButton=false
> showSleepButton=false
> showSwitchUserButton=false
> 
> Plasma will crash.
> 
> This patch check this and provide a default setting if this happens.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1203948 
> 
> Diff: http://svn.reviewboard.kde.org/r/6060/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101205/a3df0073/attachment.htm 


More information about the Plasma-devel mailing list