Review Request: Manual panel hiding [WIP]

[Aaron Seigo]

> On 2010-05-04 03:49:54, Aaron Seigo wrote:
> > any updates on this?
> 
> Will Stephenson wrote:
>     Ditto - our users are still asking for it - as they do on every release.
> 
> Aaron Seigo wrote:
>     *gasp* all of them? ;)
>     
>     more seriously, "our users" as a generic term is not a very interesting metric, since in reality it could be 10 loud users out of 1000 or it could be an actually significant %. :)
>     
>     that said ... looks like this patch is abandoned. would be nice if someone picked it up and finished it out.
> 
> Will Stephenson wrote:
>     It's the loud and unhelpful crew.
> 
> Will Stephenson wrote:
>     Stephenson picks up the ball^Wpatch and runs with it.  Currently I've switched to Plasma::Toolbutton for the hiding buttons, using layouts instead of manual hiding, made it work with vertical panels and am currently trying to figure out how to do something GlowBar-like instead of showing QToolButtons in screen corners when the panel is hidden.  I'll post a new diff for review tomorrow.  
>     
>     Oh and is there any way to get the right hiding button past the Panel Tool Box button?  containment()->layout() does not seem to include it.

first, thanks for picking this up.

as to your question, see my comments on the first version of this patch, in particular:

"instead of setting the margins on the containment, set the contents margins on the PanelView itself. then position the button inside of the PanelView itself. this is guaranteed not to break, regardless of what the containment tries to do."

this is a *view* thing (showing/hiding the view) and therefore belongs in the View itself, not anywhere in the containment.

that approach will guarantee that it works not matter what the containment does: delete every item in it, not use a linear layout, etc.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3121/#review5390
-----------------------------------------------------------


On 2010-03-04 19:19:53, Andrzej JR Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3121/
> -----------------------------------------------------------
> 
> (Updated 2010-03-04 19:19:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons.
> 
> 
> This addresses bug 158556.
>     https://bugs.kde.org/show_bug.cgi?id=158556
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp 1097398 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp 1097398 
> 
> Diff: http://reviewboard.kde.org/r/3121/diff
> 
> 
> Testing
> -------
> 
> Hiding the panels, changing states, changing positions and sizes.
> 
> 
> Thanks,
> 
> Andrzej JR
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100818/fe6532cc/attachment-0001.htm