<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/3121/">http://reviewboard.kde.org/r/3121/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 4th, 2010, 3:49 a.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">any updates on this?</pre>
</blockquote>
<p>On July 26th, 2010, 1:03 p.m., <b>Will Stephenson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ditto - our users are still asking for it - as they do on every release.</pre>
</blockquote>
<p>On July 26th, 2010, 6:23 p.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">*gasp* all of them? ;)
more seriously, "our users" as a generic term is not a very interesting metric, since in reality it could be 10 loud users out of 1000 or it could be an actually significant %. :)
that said ... looks like this patch is abandoned. would be nice if someone picked it up and finished it out.</pre>
</blockquote>
<p>On August 16th, 2010, 7:52 p.m., <b>Will Stephenson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's the loud and unhelpful crew.</pre>
</blockquote>
<p>On August 17th, 2010, 9:33 p.m., <b>Will Stephenson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Stephenson picks up the ball^Wpatch and runs with it. Currently I've switched to Plasma::Toolbutton for the hiding buttons, using layouts instead of manual hiding, made it work with vertical panels and am currently trying to figure out how to do something GlowBar-like instead of showing QToolButtons in screen corners when the panel is hidden. I'll post a new diff for review tomorrow.
Oh and is there any way to get the right hiding button past the Panel Tool Box button? containment()->layout() does not seem to include it. </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">first, thanks for picking this up.
as to your question, see my comments on the first version of this patch, in particular:
"instead of setting the margins on the containment, set the contents margins on the PanelView itself. then position the button inside of the PanelView itself. this is guaranteed not to break, regardless of what the containment tries to do."
this is a *view* thing (showing/hiding the view) and therefore belongs in the View itself, not anywhere in the containment.
that approach will guarantee that it works not matter what the containment does: delete every item in it, not use a linear layout, etc.</pre>
<br />
<p>- Aaron</p>
<br />
<p>On March 4th, 2010, 7:19 p.m., Andrzej JR Hunt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrzej JR Hunt.</div>
<p style="color: grey;"><i>Updated 2010-03-04 19:19:53</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual panel hiding patch (still in progress). Currently only horizontal panels are properly implemented, there is still a display bug whereby the plasma toolbox (cashew) ignores the contentsMargins set on the containment and thus gets covered by the hiding buttons.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hiding the panels, changing states, changing positions and sizes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=158556">158556</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h <span style="color: grey">(1097398)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp <span style="color: grey">(1097398)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.h <span style="color: grey">(1097398)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp <span style="color: grey">(1097398)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/panel.cpp <span style="color: grey">(1097398)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/3121/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>