Review Request: Fix wetter.com Ion

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5024/#review7051
-----------------------------------------------------------

Ship it!


i guess an api key worked at some point then was revoked?
if with that other key it works, ship it

- Marco


On 2010-08-14 07:26:19, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5024/
> -----------------------------------------------------------
> 
> (Updated 2010-08-14 07:26:19)
> 
> 
> Review request for Plasma and Shawn Starr.
> 
> 
> Summary
> -------
> 
> Since 4.5 the wetter.com Ion is broken which means no useful weather information for our German userbase :-(
> 
> I tracked it down to http://websvn.kde.org/?view=revision&revision=1072253 which was applied for 4.5, but never for 4.4. Given the referrenced bug report it should have never worked in 4.4, but it did. Reverting this commit, fixes the ion again.
> 
> So I ask to revert the offending commit in both trunk and branch. And I promise to investigate weather issues the next time when I notice that it is broken and not after the release :-)
> 
> In general I think it might be an idea to move the API information into the desktop file instead of constants in the header.
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/weather/ions/wetter.com/ion_wettercom.h 1157322 
> 
> Diff: http://reviewboard.kde.org/r/5024/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100814/8ebe1abb/attachment.htm