<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/5024/">http://reviewboard.kde.org/r/5024/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i guess an api key worked at some point then was revoked?
if with that other key it works, ship it</pre>
<br />
<p>- Marco</p>
<br />
<p>On August 14th, 2010, 7:26 a.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Shawn Starr.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated 2010-08-14 07:26:19</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since 4.5 the wetter.com Ion is broken which means no useful weather information for our German userbase :-(
I tracked it down to http://websvn.kde.org/?view=revision&revision=1072253 which was applied for 4.5, but never for 4.4. Given the referrenced bug report it should have never worked in 4.4, but it did. Reverting this commit, fixes the ion again.
So I ask to revert the offending commit in both trunk and branch. And I promise to investigate weather issues the next time when I notice that it is broken and not after the release :-)
In general I think it might be an idea to move the API information into the desktop file instead of constants in the header.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/KDE/4.5/kdebase/workspace/plasma/generic/dataengines/weather/ions/wetter.com/ion_wettercom.h <span style="color: grey">(1157322)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/5024/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>