preview in wallpaper dialog

[Aaron J. Seigo]

hi all ...

so .. we have that pretty preview in the wallpaper settings, completely with
a pretend monitor and everything. the preview itself looks nice ... but
 ....

... it looks pretty murderous in the dialog itself given how it distorts the
 layout and takes up space.

i spent some time today considering what the real value of it is. right now
we have in-line previews for nearly all of our wallpapers, so the preview is
mostly (though not 100%) duplicated information. for wallpapers that would
like to show a preview, they can probably do so themselves in their own
 configuration layout.

i've implemented it locally already and i think it looks a lot better, if a
little more boring. the only wallpaper that really suffers from the missing
preview, imho, is the patterns wallpaper, but that could be addressed by
 making its configuration like the images one.

which brings me to the next issue: sharing the previewer. this could be done
by sharing the delegate that paints the items via Plasma::Wallpaper,
 requiring a view with a model that provides the BackgroundDelegate roles.

thoughts?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B
 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20100811/62d537f8/attachment.sig