Review Request: Fixing positions on the fifteenPuzzle to make it solvable
Aaron Seigo
aseigo at kde.org
Wed Aug 4 20:36:22 CEST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4867/#review6797
-----------------------------------------------------------
Ship it!
one small issue below in terms of coding style, but this looks ready to go in.
/trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp
<http://reviewboard.kde.org/r/4867/#comment6669>
please stick to the coding style of the rest of the file. this should be:
if (m_id == parent->size() * parent->size()) {
m_isBlank = true;
}
or.. perhaps even simpler, just:
m_isBlank = m_id == parent->size() * parent->size();
- Aaron
On 2010-08-04 17:20:03, Alex Raymond wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4867/
> -----------------------------------------------------------
>
> (Updated 2010-08-04 17:20:03)
>
>
> Review request for Plasma and Aaron Seigo.
>
>
> Summary
> -------
>
> Previously, the initial piece arrangement for the fifteenPuzzle was:
>
> - 1 2 3
> 4 5 6 7
> 8 9 10 11
> 12 13 14 15
>
> This arrangement makes the puzzle unsolvable. So the correct initial position must be with the empty space on the last tile, instead of the first.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1159166
> /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1159166
> /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1159166
>
> Diff: http://reviewboard.kde.org/r/4867/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100804/47607310/attachment-0001.htm
More information about the Plasma-devel
mailing list