Review Request: Fixing positions on the fifteenPuzzle to make it solvable

Alex Raymond raymond.alex at gmail.com
Wed Aug 4 19:20:04 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4867/
-----------------------------------------------------------

(Updated 2010-08-04 17:20:03.485141)


Review request for Plasma and Aaron Seigo.


Changes
-------

Fixed!

The game position and the piece id were initialized with the same variable, so I made some changes to the constructor of Piece.

Also, added a boolean variable to hold the type (blank or not) of the piece.


Summary
-------

Previously, the initial piece arrangement for the fifteenPuzzle was:

-   1   2   3
4   5   6   7
8   9  10  11
12  13 14  15

This arrangement makes the puzzle unsolvable. So the correct initial position must be with the empty space on the last tile, instead of the first.


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1159166 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1159166 
  /trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1159166 

Diff: http://reviewboard.kde.org/r/4867/diff


Testing
-------


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100804/7438fed8/attachment.htm 


More information about the Plasma-devel mailing list