Review Request: share dataengine review improvements

[Artur de Souza (MoRpHeUz)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4903/#review6794
-----------------------------------------------------------

Ship it!


Great patch. Thanks for the feedback!

- Artur


On 2010-08-04 17:58:07, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4903/
> -----------------------------------------------------------
> 
> (Updated 2010-08-04 17:58:07)
> 
> 
> Review request for Plasma and Artur de Souza (MoRpHeUz).
> 
> 
> Summary
> -------
> 
> this patch set:
> 
> * changes the layout of the sources in the engine; it introduces a Mimetypes entry for all mimetypes, and populates all the plugins at the start
> * reacts to changes in ksycoca (one down side: it is brute force, it just removes all sources and starts over; would be more graceful to just add new ones, remove old ones?)
> * installs the backend .desktop files
> * cleans up some of the services files added
> 
> 
> Diffs
> -----
> 
>   /trunk/kdereview/plasma/dataengines/share/backends/imagebinca/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/imageshack/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/imgur/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/pastebinca/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/pastebincom/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/simplestimagehosting/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/wklej/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/backends/wstaw/CMakeLists.txt 1159195 
>   /trunk/kdereview/plasma/dataengines/share/plasma-dataengine-share.desktop 1159195 
>   /trunk/kdereview/plasma/dataengines/share/plasma_shareprovider.desktop 1159195 
>   /trunk/kdereview/plasma/dataengines/share/shareengine.h 1159195 
>   /trunk/kdereview/plasma/dataengines/share/shareengine.cpp 1159195 
> 
> Diff: http://reviewboard.kde.org/r/4903/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100804/9d5e5374/attachment.htm